Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

further improve pull request template #495

Merged
merged 3 commits into from
Jun 30, 2020
Merged

further improve pull request template #495

merged 3 commits into from
Jun 30, 2020

Conversation

juarezr
Copy link
Member

@juarezr juarezr commented Jun 27, 2020 •
edited
Loading

This PR has the objetive of improving comunication in PR template.
At least for me. 😄

Changes

  1. Improved the pull request template
  2. Split items in categories.
  3. Added new entries to signaling PR status

Checklist

Checklist for for pull requests including new code and/or changes to existing code...

  • Code
    • Includes unit tests
    • New functions have docstrings with examples that can be run with doctest
    • New functions are included in API docs
    • Docstrings include notes for any changes to API or behaviour
    • All changes documented in docs/changes.rst
  • Testing
    • (Optional) Tested local against remote servers
    • Travis CI passes (unit tests run under Linux)
    • AppVeyor CI passes (unit tests run under Windows)
    • Unit test coverage has not decreased (see Coveralls)
  • Changes
    • (Optional) Just a proof of concept
    • (Optional) Work in progress
    • Ready to review
    • Ready to merge

Legend

  • Not done yet
  • Finished
  • Doesn't apply to this PR

@juarezr
improve further pull request template
a7b9a59 
Dismiss if it doen't help. 😄
@coveralls
Copy link

coveralls commented Jun 27, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.2%) to 90.524% when pulling 719d574 on juarezr:petl_pr_template into 65139a5 on petl-developers:master.

alimanfoo
alimanfoo reviewed Jun 28, 2020
View reviewed changes
Copy link
Collaborator

@alimanfoo alimanfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @juarezr, nice suggestions. One typo and one question...

.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
@juarezr
Fix spelling, wrong translation and brain failure
afa6ec4 
In portuguese:
  legenda => reference, subtitle, caption, description
Easily mistaken with:
  lenda => legend, myth, tale, fable
@alimanfoo alimanfoo merged commit ace4aca into petl-developers:master Jun 30, 2020
@alimanfoo
Copy link
Collaborator

Thanks @juarezr 😄

@juarezr juarezr deleted the petl_pr_template branch September 17, 2020 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alimanfoo alimanfoo alimanfoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juarezr @coveralls @alimanfoo