Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve helper ieq() for handling null values #528

Merged
merged 2 commits into from
Oct 6, 2020
Merged

improve helper ieq() for handling null values #528

merged 2 commits into from
Oct 6, 2020

Conversation

juarezr
Copy link
Member

@juarezr juarezr commented Oct 6, 2020 •
edited
Loading

This PR has the objective of improving tests.

Changes

  1. Teached helper ieq to handle None

Checklist

Checklist for for pull requests including new code and/or changes to existing code...

  • Testing
    • (Optional) Tested local against remote servers
    • Travis CI passes (unit tests run under Linux)
    • AppVeyor CI passes (unit tests run under Windows)
    • Unit test coverage has not decreased (see Coveralls)
  • Changes
    • Ready to review
    • Ready to merge

@juarezr juarezr requested a review from alimanfoo October 6, 2020 01:30
@juarezr juarezr added the Maintainability Issues for code modernization, improve development, testing label Oct 6, 2020
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 91.94% when pulling 2893d8f on juarezr:ieq into 52447c0 on petl-developers:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 91.94% when pulling 2893d8f on juarezr:ieq into 52447c0 on petl-developers:master.

@juarezr
Copy link
Member Author

juarezr commented Oct 6, 2020

continuous-integration/travis-ci Expected — Waiting for status to be reported.

See travis-ci/travis-ci#10204

@juarezr juarezr merged commit b8068f8 into petl-developers:master Oct 6, 2020
@juarezr juarezr deleted the ieq branch October 6, 2020 16:17
@juarezr juarezr restored the ieq branch October 6, 2020 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alimanfoo alimanfoo Awaiting requested review from alimanfoo

Assignees
No one assigned
Labels
Maintainability Issues for code modernization, improve development, testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juarezr @coveralls