Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document behavior of multi-field convert-with-row #532

Merged
merged 1 commit into from
Dec 24, 2020
Merged

Document behavior of multi-field convert-with-row #532

merged 1 commit into from
Dec 24, 2020

Conversation

chrullrich
Copy link

@chrullrich chrullrich commented Dec 10, 2020

Fixes #531.

This PR has the objective of... setting in stone the fact that convert() works the way it does by design, not accident.

Changes

  1. Improved the docs about... petl.transform.conversions.convert() when used with multiple conversions in its whole-row mode.

Adds a doctest. doctests pass; I cannot get the whole test setup working at all, let alone actually test anything.

Checklist

Checklist for for pull requests including new code and/or changes to existing code...

  • Code
    • Includes unit tests
    • New functions have docstrings with examples that can be run with doctest
    • New functions are included in API docs
    • Docstrings include notes for any changes to API or behaviour
    • All changes documented in docs/changes.rst
  • Testing
    • (Optional) Tested local against remote servers
    • Travis CI passes (unit tests run under Linux)
    • AppVeyor CI passes (unit tests run under Windows)
    • Unit test coverage has not decreased (see Coveralls)
  • Changes
    • (Optional) Just a proof of concept
    • (Optional) Work in progress
    • Ready to review
    • Ready to merge

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.003%) to 91.94% when pulling f042b28 on chrullrich:issue-531 into b8068f8 on petl-developers:master.

@juarezr juarezr merged commit 128b930 into petl-developers:master Dec 24, 2020
@chrullrich chrullrich deleted the issue-531 branch March 26, 2021 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is the behavior of multi-field convert-with-row contractual?
4 participants