Disable Scroll html #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pexea12
reviewed
Apr 18, 2018
src/components/script.js
Outdated
| showLightBox: { | ||
| type: Boolean, | ||
| default: true, | ||
| default: true |
There was a problem hiding this comment.
I think you should keep the little comma there. We use Airbnb Javascript Style Guide
There was a problem hiding this comment.
Thanks for your reply I will change it
pexea12
reviewed
Apr 18, 2018
src/components/script.js
Outdated
| }, | ||
|
|
||
| data() { | ||
| data () { |
|
I have just commented on the changes of your pull request. I would approve your pull request if you keep the style unchanged and change only what necessary. |
imcvampire
reviewed
Apr 19, 2018
src/components/script.js
Outdated
|
|
||
| disableScroll: { | ||
| type: Boolean, | ||
| default: false |
There was a problem hiding this comment.
I think this is a good improvement so we can turn on it by default
There was a problem hiding this comment.
Thanks for your comment, I change it :)
pexea12
reviewed
Apr 20, 2018
src/components/style.css
Outdated
|
|
||
| .no-scroll { | ||
| overflow-y: hidden; | ||
| } |
There was a problem hiding this comment.
A little change: can you add a new line to the end of this file? Sorry I didn't notice it until now.
imcvampire
previously approved these changes
Apr 21, 2018
imcvampire
approved these changes
Apr 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add disableScroll property to avoid scrolling views behind lightbox