add rspec-run-last-failed to rerun only failed examples #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have not tested it yet, but I think this is an awesome feature 👍 |
| @@ -668,6 +676,10 @@ or a cons (FILE . LINE), to run one example." | |||
| (message "No spec files found!") | |||
| (rspec-compile (rspec-runner-target spec-files) opts))) | |||
|
|
|||
| (defvar rspec-last-failed-specs | |||
| '() | |||
There was a problem hiding this comment.
'() is the same as nil, and no need to put it on a separate line.
rspec-run-last-failed will re-run the specs that failed during the last invocation. By default this is bound to C-c ,f.
|
Changes:
Thanks for the comments! |
| (failure-regexp "^rspec \\([0-9A-Za-z@_./:-]+\\.rb:[0-9]+\\)") | ||
| (failures (save-match-data | ||
| (let ((pos 0) matches) | ||
| (while (string-match failure-regexp body pos) |
There was a problem hiding this comment.
This would be better performed with re-search-forward. You don't copy the buffer text into a string; instead use save-excursion, (goto-char (point-min)), and traverse the buffer till the end while saving the matches,
|
Thanks for the comment. I've updated the logic, hopefully correctly. |
|
Dropped the |
|
Squash-merged. Thanks! |
|
👍 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rspec-run-last-failed will re-run the specs that failed during the last invocation. By default this is bound to
C-c ,f.I'm not an elisp pro so I'm sure there's some cleanup that can be done here. Feedback welcome!