Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "approve & whitelist" to be inclusive and more reader friendly #252

Closed
jeremyfelt opened this issue Jan 14, 2020 · 1 comment
Closed

Comments

@jeremyfelt
Copy link
Contributor

@jeremyfelt jeremyfelt commented Jan 14, 2020

Howdy. Thanks for the excellent plugin! I've really been enjoying playing around with Webmentions finally.

I'd like to propose changing the "Approve & Whitelist" text below each pending comment to something more inclusive and reader friendly.

"Approve and Allowlist" doesn't really read right, but "Approve and always allow" or "always allow" seem like decent alternatives. In addition to being inclusive, I think that an average blog owner would be more confident knowing what "always allow" means rather than "whitelist".

It appears that the language can change throughout as the option stored in the database is webmention_approve_domains, which does not cause any back-compat issues. It may be that the function, transition_to_whitelist needs to remain as is in case anyone had been removing that filter through another plugin.

I'm happy to submit a PR with changes if this fits. :)

@dshanske

This comment has been minimized.

Copy link
Collaborator

@dshanske dshanske commented Jan 14, 2020

No objection. I thought of doing this when the feature was working better, as it seems to be malfunctioning at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.