Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set stats type #83

Merged
merged 1 commit into from
Oct 29, 2020
Merged

Set stats type #83

merged 1 commit into from
Oct 29, 2020

Conversation

marioyc
Copy link
Contributor

@marioyc marioyc commented Oct 21, 2020

Call _set_mode in Monitor to set the stats type as done here

@marioyc marioyc self-assigned this Oct 21, 2020
@tkelestemur
Copy link
Contributor

tkelestemur commented Oct 23, 2020 •
edited
Loading

Since the PFRL's Monitor call the __init__ function of the Gym's Monitor, it already sets the mode right? Why do we need to set it again?

Edit: PPO Atari example sets the mode while wrapping the environments so that might mean that functional already works.

@marioyc
Copy link
Contributor Author

marioyc commented Oct 23, 2020

that will set the type for the initial self.stats_recorder but we overwrite with PFRL's _StatsRecorder which mode doesn't affect

@tkelestemur
Copy link
Contributor

Oh okay, that make sense. I went ahead and tried your change and it successfully labels eval environments as e in .json files.

prabhatnagarajan
prabhatnagarajan approved these changes Oct 29, 2020
View reviewed changes
Copy link
Contributor

@prabhatnagarajan prabhatnagarajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good catch.

@prabhatnagarajan prabhatnagarajan merged commit 4c30c1d into master Oct 29, 2020
@prabhatnagarajan prabhatnagarajan deleted the stats-recorder-type branch October 29, 2020 10:01
@muupan muupan added the enhancement New feature or request label Dec 11, 2020
@muupan muupan added this to the v0.2.0 milestone Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prabhatnagarajan prabhatnagarajan prabhatnagarajan approved these changes

Assignees

@marioyc marioyc

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@marioyc @tkelestemur @prabhatnagarajan @muupan