Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T13445 ability to change the flash html template #13530

Merged
merged 10 commits into from
Oct 18, 2018
Merged

T13445 ability to change the flash html template #13530

merged 10 commits into from
Oct 18, 2018

Conversation

niden
Copy link
Member

@niden niden commented Oct 16, 2018

Hello!

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the Contributing Guidelines?
  • I have checked that another pull request for this purpose does not exist.
  • I wrote some tests for this PR.

Added the ability to use a custom template for the flash messenger. The template must contain two strings %cssClass% and %message% so that the classes and message can be injected.

Thanks

@niden niden requested a review from sergeyklay October 16, 2018 18:39
@niden niden added this to the 4.0.0 milestone Oct 16, 2018
@niden
Copy link
Member Author

niden commented Oct 18, 2018

cc @sergeyklay

Copy link
Contributor

@sergeyklay sergeyklay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general looks good to me (except methods reordering)

@niden niden merged commit 43e6a58 into phalcon:4.0.x Oct 18, 2018
@niden niden deleted the T13445-ability-to-change-the-flash-html-template branch October 31, 2018 17:45
@niden niden added the documentation Documentation required label Apr 9, 2019
@niden niden added 4.0 enhancement Enhancement to the framework and removed documentation Documentation required labels Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to the framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants