Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T13336 find first null #13826

Merged
merged 9 commits into from Feb 16, 2019
Merged

T13336 find first null #13826

merged 9 commits into from Feb 16, 2019

Conversation

niden
Copy link
Sponsor Member

@niden niden commented Feb 14, 2019

Hello!

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the Contributing Guidelines?
  • I have checked that another pull request for this purpose does not exist.
  • I wrote some tests for this PR.

When passing anything other than a string, array or null in findFirst() will throw an exception

Thanks

* upstream/4.0.x:
  [4.0.x] - Added unicode flag for email filter
* upstream/4.0.x:
  [#13488] - Removed commas that crept in the .env file
  [#13488] - Minor corection to debug; Added funcitonality for getting filtered vars; Added tests
  [#13488] - Initial changes for the feature; adding methods
* upstream/4.0.x:
  Updated changelog
  Updated CFLAG default build param
  keep the actionName as set, do cache the methodName in `getActiveMethod` instead (use action mapping to cover Dispatcher `forward`ing case?)
  move formatter into setter
  give up on `camelize`, use a new approach
  unit tests
  Camel-case the action name (before call in handler)
  Correct pull request template
  Fix .editorconfig
  Amended .gitignore
  Bump version
  Fixed preparing release on AppVeyor
  Update change log
  Regenerated build
  Regenerated ext
  Updating the changelog
* upstream/4.0.x:
  Updated the changelog
  [#13808] - Updating ext folder
  [#13808] - Adjusting tests
  [#13808] - Renaming ACL elements
* upstream/4.0.x:
  Update CHANGELOG-4.0.md
  Updated changelog
  Added geSetMetaData test Modified some unit tests to use metaData
  Modified existing tests to work with the additional MetaData
  Modified Phalcon\Mvc\Model to use Phalcon\Message::setMetaData() instead of setModel()
  Added new MetaData variable to Phalcon\Message. Modified Phalcon\MessageInterface accordingly
  Corrected typo
* upstream/4.0.x:
  [#2182] - Updated the changelog and PR template
  [#2182] - Added before/after compile events for Volt
  [#2182] - Removed some obsolete tests; Added tests for engine/render events
  Updated changelog
  fix tests
  change tests
  fix stan
  Add `Dispatcher::toCamelCase()` method
  [#13819] - Updated the changelog
  [#13819] - Removing css/js optimizers from the config
  [#13819] - Updating ext/
  [#13819] - Removed minifiers
  [#13819] - Marked tests as skipped
@niden niden added Bug - Low breaks bc Functionality that breaks Backwards Compatibility labels Feb 14, 2019
@niden
Copy link
Sponsor Member Author

niden commented Feb 14, 2019

cc @sergeyklay

@niden niden added this to In progress in 4.0.0 Release via automation Feb 14, 2019
@codecov
Copy link

codecov bot commented Feb 14, 2019

Codecov Report

Merging #13826 into 4.0.x will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            4.0.x   #13826      +/-   ##
==========================================
+ Coverage   66.24%   66.24%   +<.01%     
==========================================
  Files         450      450              
  Lines       89628    89636       +8     
==========================================
+ Hits        59375    59383       +8     
  Misses      30253    30253
Impacted Files Coverage Δ
ext/phalcon/mvc/model.zep.c 66.82% <0%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af35d0c...563037d. Read the comment docs.

Copy link
Member

@sergeyklay sergeyklay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@niden niden merged commit c310058 into phalcon:4.0.x Feb 16, 2019
4.0.0 Release automation moved this from In progress to Done Feb 16, 2019
@niden niden deleted the T13336-find-first-null branch March 13, 2019 20:21
@niden niden added the documentation Documentation required label Apr 9, 2019
@niden niden added the 4.0 label Dec 2, 2019
@niden niden removed the documentation Documentation required label Dec 15, 2019
@niden niden added bug A bug report status: low Low and removed Bug - Low labels Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaks bc Functionality that breaks Backwards Compatibility bug A bug report status: low Low
Projects
No open projects
4.0.0 Release
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants