Removed property comments in Select Helper #16494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niden
added
documentation
niden
approved these changes
Jan 5, 2024
|
Thank you @kuhler-Stratege |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
In raising this pull request, I confirm the following:
Small description of change:
My IDE (phpstorm) was getting confused because inside the IDE stubs for the
Phalcon\Html\Helper\Input\Selectclass there are@propertycomments for the class fields (elementTag,inOptGroupandselected) as well as the class fields themselves. My IDE was thinking that each of the fields are actually two fields with the same name but one public and one protected.This is why I deleted the
@propertycomments to solve this confusion of my IDE.Thanks