Fix valid function for the first call #2424
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit 5c9bf86,
Problem : the function valid respond false the first time when the fetchAll must be done.
Solution : set directly rows field after the fetch.
Example to reproduce :
#1 Create table
CREATE TABLE IF NOT EXISTS
user
(user_id
int(10) unsigned NOT NULL AUTO_INCREMENT,email
varchar(70) CHARACTER SET utf8 NOT NULL,password
char(32) CHARACTER SET utf8 NOT NULL,PRIMARY KEY (
user_id
),UNIQUE KEY
email_password
(email
,password
)) ENGINE=InnoDB DEFAULT CHARSET=latin1 AUTO_INCREMENT=3 ;
INSERT INTO
user
(user_id
,email
,password
) VALUES(1, 'example1@gmail.com', 'pass1'),
(2, 'example2@test.com', 'pass2');
#2 (use scaffold of phalcon-devtool)
phalcon scaffold --table-name user
#3 Search all result (juste enter in http://127.0.0.1/user/index page
or check like this :
$users = User::find();
while ($users->valid() !== false) {
echo "user : " . $users->current()->email . '
';
}
commit 8af3f1e,
Fix resultSet->seek function. replace range by while loop because range(0, 0) do one loop and apply next function.