Skip to content

Don't use session if session not started #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 7, 2017
Merged

Don't use session if session not started #434

merged 4 commits into from
Dec 7, 2017

Conversation

sergeyklay
Copy link
Contributor

  • Don't use session if session not started
  • Fixed memcached session config
  • Improved notifications settings

@sergeyklay
Client options must be instance of array
c939959
@sergeyklay
Don't use session if session not started
34715bb 
Actually this is a Phalcon bug.

The `Phalcon\Session\Adapter::start` doesn't create an empty _SESSION
for PHP SAPI `cli', so Zephir throws exception:

ZEPHIR_THROW_EXCEPTION_STR(zend_exception_get_default(), "Invalid
superglobal");
@sergeyklay
Improved notifications settings
fa492ae
@sergeyklay
Enable NotificationsCest
820dc5f
@sergeyklay sergeyklay merged commit d0a774a into phalcon:3.x Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sergeyklay