ignoreTube method added @ incubator/Library/Phalcon/Queue/Beanstalk/Exte...

[tapan-kumar-thapa]

Hi Team,

I have added ignoreTube as well as getResponseLinesText method @ incubator/Library/Phalcon/Queue/Beanstalk/Extended.php as per beanstalk protocol defination (https://github.com/kr/beanstalkd/blob/master/doc/protocol.txt) to ignore any watched tube.

It is working fine at my laptop and server. Please review and provide this feature to rest of world.

Thanks in advance for providing such a great framework.

Regards
Tapan Thapa

[xboston]

Good =)
@endeveit , please check this?

[endeveit]

Everything seems well except code style.

1. The name of method «getResponseLinesText» is not semantic maybe it should be named something like «getWatchingResponse»
2. There is no phpDoc type named «text» only «string»
3. In reformat code #79 the code style indentation was changed to tabs

[tapan-kumar-thapa]

1. method name getResponseLinesText has been changed to getWatchingResponse to make best practice in place.
2. Code formatting has been changed from SPACES to TAB.
3. Correct phpdoc has been set on getWatchingResponse method from text to string.

[xboston]

@endeveit good?

[endeveit]

Here is the unified diff for additional code style fixes https://gist.github.com/endeveit/8368438

[tapan-kumar-thapa]

patched applied.

[endeveit]

👍

[tapan-kumar-thapa]

Also would like to know which text editor you are using with which formatting plugin. I am using sublime text 2.

[endeveit]

I'm using Intellij Idea with PHP plugin.
But source code formatting i do with php-cs-fixer.

[tapan-kumar-thapa]

Thanks for the info. Let me know if my code looks ok now. If yes than please merge it or confirm if any deviation.

[endeveit]

@xboston now everything is good

[xboston]

Thanks guys!

[tapan-kumar-thapa]

Your welcome...
I am glad that i have given something back to community.