[wip] Add methods to register a set of dependencies #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanKoelzer
changed the title
JanKoelzer
force-pushed
the
feature/registerSetOfDeps
branch
from
2ab5660 to
5808dbd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[wip] because we need to check, if this solution works for OPAL.
Six methods of the following form are added:
Cell.when**: (Cell, Callback)* => Unit
Those deps are registered atomically, so this should make the use of CellCompleter.sequential by the client obsolete, i.e. this fixes #146 .
This PR also changes, how duplicate dependencies are handled:
cell1.when(cell2, f)
cell1.when(cell2, g)
Before, the second dep has been discarded, now the first one is overwritten. That matches the behaviour of the new method
cell1.when((cell2, f), (cell2, g))