Closes #2154 fix_dthcaus: fix derive_var_dthcaus()

[bundfussr]

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the devel branch until you have checked off each task.

• Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
• Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
• Updated relevant unit tests or have written new unit tests, which should consider realistic data scenarios and edge cases, e.g. empty datasets, errors, boundary cases etc. - See Unit Test Guide
• If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
• Update to all relevant roxygen headers and examples, including keywords and families. Refer to the categorization of functions to tag appropriate keyword/family.
• Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
• Address any updates needed for vignettes and/or templates
• Update NEWS.md under the header # admiral (development version) if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers)
• Build admiral site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.
• Address or fix all lintr warnings and errors - lintr::lint_package()
• Run R CMD check locally and address all errors and warnings - devtools::check()
• Link the issue in the Development Section on the right hand side.
• Address all merge conflicts and resolve appropriately
• Pat yourself on the back for a job well done! Much love to your accomplishment!

[github-actions]

Package	Line Rate	Health
admiral	98%	✔
Summary	98% (4419 / 4489)	✔

[zdz2101]

Suggested change

	Version: 0.12.2.9000
	Version: 0.12.3

since this should be a one-time fix, no need to add development flow to it?

[bms63]

I don't think we should do a another bug fix release. should just ship out with 1.0

[bms63]

im unclear if CRAN would even accept a third patch in 3 weeks

[zdz2101]

If so, we can remove my suggestion, but merge to main instead of patch right?

[bms63]

yes merge to main

[bundfussr]

@rossfarrugia , would like to have this fixed soon because the issue was detected by a Roche study using admiral.

Maybe we could do a patch release but do not submit it to CRAN? However, it may be confusing for health authorities if a study does a submission with admiral 0.12.3 and this version is not available on CRAN.

What do you think?

[rossfarrugia]

my take on this is its not a minor bug in terms of impact - its a common derivation that pretty much every study will use, it relates to death information which is key safety info, and currently it doesn't work as documented in admiral. so for me thats something i'd not want to wait for as a user. so i'd be in favour of releasing as 0.12.3 and if CRAN don't accept then nothing we can do about that. at least users would have an option to install and use this from github until 1.0.0 comes later.

[bms63]

okay

@bundfussr is this branched off release tag 12.2?

[bundfussr]

I branched off patch, which should be the same as tag 12.2.

[bundfussr]

Updated to 0.12.3.

[zdz2101]

small detail, but for the purpose of merging it in relatively soon(?) we can skip the 9000 versioning

[bms63]

Suggested change

	- `derive_var_dthcaus()` was fixed. If a subject has observations in more than
	one of the sources, the one from the last source was selected regardless of the
	date. Now the function works as described in its documentation. (#2154)
	- Fixed a bug in `derive_var_dthcaus()` where if a subject has observations in more than
	one of the sources, the one from the last source was selected regardless of the
	date. Now the function works as described in its documentation. (#2154)

[bundfussr]

Updated

[bms63]

Do we need to worry about any partial dates here since these are ---DTC variables?

[bms63]

I guess a death would always have an exact date. just musing here

[bundfussr]

No need to worry. derive_var_dthcaus() expects dates (not DTC variables). The users have to handle partial dates in a preprocessing step or on the definition of the source objects (like in the examples).