Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add equality for transformations + tests #518

Closed
wants to merge 3 commits into from

Conversation

Nyan11
Copy link
Contributor

@Nyan11 Nyan11 commented Jun 2, 2024

No description provided.

@Nyan11 Nyan11 changed the title Add transformation tests Add equality for transformations + tests Jun 2, 2024
@tinchodias
Copy link
Collaborator

I have to check the reason of the red tests

@tinchodias
Copy link
Collaborator

tinchodias commented Jun 12, 2024

I inspected change by change and don't understand how can this change affect the rendering of text (and the textd hit testing). Example (left: actual, right: "expected"):
Screenshot 2024-06-11 at 22 02 54

I wonder if what is currently "expected" was buggy, and if after this change in the equals it's more correct now. Any clue, @Nyan11 ?

The test can be run with (BARenderTest buildSuiteFor: #buildTextAttributes) run.

To inspect the diff I captured, inspect: (BARenderTest buildSuiteFor: #buildTextAttributes) tests anyOne newPixelComparison


EDIT: In my capture above, the diff shows all texts ~ half pixel up. Maybe like if in expected Form, the baseline is an integer value but in actual Form it is a Float.

@tinchodias tinchodias deleted the branch pharo-graphics:dev-1.0 August 10, 2024 00:32
@tinchodias tinchodias closed this Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants