Update Fuel from upstream #14132
Merged
Update Fuel from upstream #14132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove FuelPlatform - properly store / load class comments and stamps - skip problematic tests when clean blocks are enabled - rename Fuel-Tests-Core to Fuel-Core-Tests Fixes pharo-project#14131
This was referenced Jun 27, 2023
- remove dependency to FuelPlatform - remove BaselineOfFuelPlatform - fix depdendency on renamed Fuel-Core-Tests
|
Fixed a lingering reference. |
|
Test run looks good to me. |
|
Hmm... lots of tests failing, e.g. |
MarcusDenker
added
the
Status: Need more work
|
Oh silly me… I did not look at the tests tab. I’ll take care of it.
…--
Sent from Canary (https://canarymail.io)
On Friday, Jun 30, 2023 at 8:17 AM, Marcus Denker ***@***.*** ***@***.***)> wrote:
Hmm... lots of tests failing, e.g.
FLCreateTraitSerializationTest>>testCreateWithInternalTrait fais with: 'Attempt to read undeclared variable FLPlatform'
—
Reply to this email directly, view it on GitHub (#14132 (comment)), or unsubscribe (https://github.com/notifications/unsubscribe-auth/AAB5GVZOPVFBZ34ZQDURJRTXNZVO7ANCNFSM6AAAAAAZWCH3YM).
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
Looks good now, I think. There was some random error though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14131