Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor merging strategy in Chain finder to avoid duplicates #34

Closed
kpicaza opened this issue Oct 11, 2021 · 0 comments · Fixed by #36
Closed

Refactor merging strategy in Chain finder to avoid duplicates #34

kpicaza opened this issue Oct 11, 2021 · 0 comments · Fixed by #36
Labels
enhancement New feature or request Hacktoberfest HacktoberFest related issues

Comments

@kpicaza
Copy link
Member

kpicaza commented Oct 11, 2021

Epic: pheature-flags/pheature-flags#294

With the current implementation, we are emerging the result of every finder using array merge, this can cause duplicate results when the same toggle id is present in different finders, doing an array_replace_recursive instead of array merge will solve this issue.
@kpicaza kpicaza added enhancement New feature or request Hacktoberfest HacktoberFest related issues labels Oct 11, 2021
@kpicaza kpicaza mentioned this issue Oct 11, 2021
Closed
kpicaza added a commit that referenced this issue Oct 19, 2021
@kpicaza
[#34] adjust chain finder merging strategy
924e76a
@kpicaza kpicaza mentioned this issue Oct 19, 2021
Merged
kpicaza added a commit that referenced this issue Oct 19, 2021
@kpicaza
[#34] adjust chain finder merging strategy
8c9e9ef
kpicaza added a commit that referenced this issue Oct 19, 2021
@kpicaza
[#34] adjust chain finder merging strategy
5c3c754
kpicaza added a commit that referenced this issue Oct 19, 2021
@kpicaza
[#34] adjust chain finder merging strategy
4328a0c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request Hacktoberfest HacktoberFest related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#34] adjust chain finder merging strategy pheature-flags/toggle-core
1 participant
@kpicaza