Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#34] adjust chain finder merging strategy #36

Merged
merged 1 commit into from
Oct 19, 2021
Merged

[#34] adjust chain finder merging strategy #36

merged 1 commit into from
Oct 19, 2021

Conversation

kpicaza
Copy link
Member

@kpicaza kpicaza commented Oct 19, 2021

Closes #34

@kpicaza kpicaza added enhancement New feature or request Hacktoberfest HacktoberFest related issues labels Oct 19, 2021
@codecov
Copy link

codecov bot commented Oct 19, 2021 •
edited
Loading

Codecov Report

Merging #36 (5c3c754) into 1.0.x (3677949) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##               1.0.x       #36   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity        99       101    +2     
===========================================
  Files             23        23           
  Lines            234       237    +3     
===========================================
+ Hits             234       237    +3
Impacted Files Coverage Δ
src/Read/ChainFeatureFinder.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3677949...5c3c754. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Oct 19, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

xserrat
xserrat approved these changes Oct 19, 2021
View reviewed changes
Copy link
Contributor

@xserrat xserrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏽👏🏽

@kpicaza kpicaza merged commit 4328a0c into 1.0.x Oct 19, 2021
@kpicaza kpicaza deleted the issue#34 branch October 19, 2021 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xserrat xserrat xserrat approved these changes

@pcs289 pcs289 Awaiting requested review from pcs289

Assignees
No one assigned
Labels
enhancement New feature or request Hacktoberfest HacktoberFest related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor merging strategy in Chain finder to avoid duplicates
2 participants
@kpicaza @xserrat