A couple of fixes #32
Conversation
|
@Darkelectro I'm currently unable to test the fix out. Will merge once that's done. |
|
Alright. Forgot to mention that this may resolve #20 Worked without the |
|
This new PR fixes #12. |
|
ping @phenax |
|
applied the changes to local script from PR 1a18d8a and was still getting goofy behavior when opening new floating windows or un-hiding floating windows... sometimes the layout and the floating window were un-effected; other times, either the tiled layout got messed up or one dimension of the floating window would be reduced to zero (basically just borders visible). Found this from another fork: adding .!floating to the node_filter in the layouts where applicable seems to help, nothing strange observed so far, but need to test more.... |
|
still cases where changes based on PR and .!floating filter fail. Example: set 'tall' (maybe others) layout on desktop, open ONE terminal... now launch an application w/ state=floating rule (lxappearance tested). The floating window gets squashed to zero width dimension (height unchanged). Things seem normal when two or more tiled windows are open. |
|
I think it depends on the floating app. Haven't been able to reproduce though. |
| @@ -123,7 +123,24 @@ start_listener() { | |||
|
|
|||
| [[ "$source" != "$dest" ]] && recalculate_layout; | |||
| else | |||
| recalculate_layout; | |||
| desk_file="/tmp/bsp-layout_desktop.txt" | |||
There was a problem hiding this comment.
Could you move this to util/state.sh and inside the /tmp/bsy-layout.state/ directory? The api will be much cleaner as some_function 1 instead of the file name being repeated and echo-redirect in multiple places.
i confirm that the problem still is present. see this clip |
|
and apart from that, i have to admit i'm not sure what this PR is doing... @darkelectron, do you still have in mind what you wanted to do here? that would be really great to help me figure out why the floating bug isn't resolved 😋 |
|
Hi @darkelectron 👋 😋 as this PR has ben stale for more than a year now, we've decided with @phenax to move the changes to a2n-s/ignore and apply the requested changes there 👍 hope you'll understand 😉 |
No description provided.