-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Layout exemplar documentation #1474
Comments
We should create a page for this, and DIRECTLY embed iframes with sandboxes that illustrate different concepts. We should also take the demos from the sun demo and put them instead in this exemplar documentation. I'll set up a documentation (html) page that we can use for this. Presumably in scenery-phet. |
This exemplar documentation could also document other things, like how to use common components. |
I'm running up against Chrome failing for trying to concurrently request too many resources (once I've upped the number of iframes): Online, Firefox is suggested, or batching / lazy loading the iframes. Alternatively, I think I'm going to take a stab at figuring out if we can build a package of scenery/scenery-phet/sun that has the required general components (scenery-phet is somewhat helpful for PhetFont). Then we'd be able to use the approach used for the scenery documentation, and it would load faster. |
Additionally, packaging all of those together would be presumably useful for developers outside of PhET. |
https://phetsims.github.io/phet-lib/doc/layout-exemplars.html is up and running! |
We have converted all the sun demos over to the exemplar documentation. Next steps:
|
Reviewed with @marlitas, and it looks like the normal layout documentation (with adjusted layoutOptions) covers all of the basic examples. The "Removing layout demo from Sun" is done, and it sounds like it will be best to add case-by-case examples to here in the future. Closing! |
…t layout exemplars to layout page, see phetsims/scenery#1474
…t layout exemplars to layout page, see #1474
Noted in #1418:
It would be great to take some cases from a dynamic-layout sim, screenshot them + markup showing code snippets or what layout was used where.
The text was updated successfully, but these errors were encountered: