Skip to content

expose DragListeners for Slider thumb and track #680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pixelzoom opened this issue Jan 27, 2021 · 2 comments
Closed

expose DragListeners for Slider thumb and track #680

pixelzoom opened this issue Jan 27, 2021 · 2 comments

Comments

@pixelzoom
Copy link
Contributor

For phetsims/fourier-making-waves#31, we need to know the state of the DragListeners associated with a Slider's thumb and track -- specifically their isHighlightedProperty value. Slider adds the DragListener to the thumb, SliderThumb adds its own DragListener. These listeners are currently not part of the public APIs.

@jonathanolson and I also considered added in isHighlightedProperty to Slider, derived from isHighlightedProperty of the thumb and track DragListeners. But we suspect that there be a need to access other DragListener Properties in the future, so exposing them seems more general and future-proof.

@pixelzoom
Copy link
Contributor Author

Done in the above commit. @jonathanolson would you mind doing a quick review, since you and I discussed this?

@jonathanolson
Copy link
Contributor

Looks great to me! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants