Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit Testing #23

Closed
phiamo opened this issue Jan 12, 2012 · 7 comments
Closed

Unit Testing #23

phiamo opened this issue Jan 12, 2012 · 7 comments

Comments

@phiamo
Copy link
Owner

phiamo commented Jan 12, 2012

Hi folks, do you have any idea how to ahieve unittesting the best way for this bundle?
i could of course do string comparison for input output, but i am atm not sure if thats a nice way.
Maybe it is cause markup shouldnt change, css might.
But i would like to have some input.
Cheers Phil

@sstok
Copy link
Contributor

sstok commented Oct 16, 2013

I think testing the CSS and HTML output is something that can only done manually.
Also this testing would be very basic as we should not redo the tests already by the Bootstrap team.

But testing the Navbar extension (if it still exists), and the Configuration is something that should be automatically tested.

Testing the container configuration can actually be done very easily with.
https://github.com/matthiasnoback/SymfonyDependencyInjectionTest

@phiamo
Copy link
Owner Author

phiamo commented Oct 24, 2013

Yes thought so too thanks for the link!

@isometriks
Copy link
Collaborator

Might we use the DomCrawler to check for certain classes and number of classes when forms are rendered? Could also check on erroneous forms that the error messages showed up as well.

@phiamo
Copy link
Owner Author

phiamo commented Oct 4, 2014

we could.
travis should be abled to execute those tests, so if there is a trainee around who needs to learn howto write tests, this might be a nice job

@phiamo
Copy link
Owner Author

phiamo commented Jan 12, 2015

#956 introduced a new TypeTest i think for others relying on us thats a step forward we could and should probably add more tests for us, but i think thats not as urgent as other things

@isometriks
Copy link
Collaborator

Gonna close this. We still need more tests but at least we have some now!

#1010

@phiamo
Copy link
Owner Author

phiamo commented Jan 13, 2015

yehaw !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants