Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minification libraries #27

Merged
merged 2 commits into from
Nov 29, 2024
Merged

Conversation

AramZS
Copy link
Contributor

@AramZS AramZS commented Nov 28, 2024

This is a pretty basic PR just to add some additional logging and update the package.json and lockfile versions of the underlying libraries used by this plugin. It solved a bunch of weird problems I encountered trying to use the one currently advertised in the Netlify search. I didn't really want to post two plugins, I figured it would be better to see if I could help with updating yours. This does seem to work well in my testing.

Thanks for putting together this initial plugin @philhawksworth ! Such a great idea. Hopefully this little tweak will help make it more broadly used.

@philhawksworth philhawksworth merged commit b8add43 into philhawksworth:master Nov 29, 2024
@philhawksworth
Copy link
Owner

That's helpful. Thanks a lot, @AramZS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants