KAFKA-14950: implement assign() and assignment() #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lianetm
reviewed
May 2, 2023
| consumer = spy(newConsumer(time, new StringDeserializer(), new StringDeserializer())); | ||
| consumer.assign(singleton(new TopicPartition("foo", 3))); | ||
| assertTrue(consumer.subscription().isEmpty()); | ||
| assertTrue(consumer.assignment().isEmpty()); |
There was a problem hiding this comment.
Shouldn't it be expected to have the foo-3 assignment here? (assigned from user in the subscriptionState as a result of the previous consumer.assign)
There was a problem hiding this comment.
😓 - I guess the test never passed.
kirktrue
added a commit
that referenced
this pull request
May 24, 2023
…nly closed once Added IdempotentCloser to ensure resources are only closed once. While this class is broadly useful, it will be constrained to consumer internals until a later date.
philipnee
pushed a commit
that referenced
this pull request
Jun 9, 2023
…nly closed once Added IdempotentCloser to ensure resources are only closed once. While this class is broadly useful, it will be constrained to consumer internals until a later date.
philipnee
pushed a commit
that referenced
this pull request
Sep 11, 2023
…nly closed once Added IdempotentCloser to ensure resources are only closed once. While this class is broadly useful, it will be constrained to consumer internals until a later date.
philipnee
pushed a commit
that referenced
this pull request
Sep 11, 2023
…nly closed once Added IdempotentCloser to ensure resources are only closed once. While this class is broadly useful, it will be constrained to consumer internals until a later date.
philipnee
added a commit
that referenced
this pull request
Sep 11, 2023
…es are only closed once" This reverts commit 76d5c96.
philipnee
pushed a commit
that referenced
this pull request
Sep 13, 2023
…nly closed once Added IdempotentCloser to ensure resources are only closed once. While this class is broadly useful, it will be constrained to consumer internals until a later date.
philipnee
pushed a commit
that referenced
this pull request
Sep 13, 2023
…nly closed once Added IdempotentCloser to ensure resources are only closed once. While this class is broadly useful, it will be constrained to consumer internals until a later date.
philipnee
added a commit
that referenced
this pull request
Sep 13, 2023
…es are only closed once" This reverts commit 76d5c96.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assing()