Add Docker health checks to Consul and Memcached #168
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the initial PR that added health checks, an improvement in #162 and the use of the health checks in #154, we should use the health checks in as many test containers as possible, to benefit from the mechanism and reduce build time in CI.
This PR adds health checks for Consul and Memcached.
As their images don't have the necessary tooling installed by default, and we don't want to execute the main server process as
root
, we instead run a separatedocker exec
command to install the required tooling, while the health checks are already running (but running into errors like "curl not found").