Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker health checks to Consul and Memcached #168

Merged
merged 1 commit into from
Jan 21, 2024

Conversation

philippgille
Copy link
Owner

Following the initial PR that added health checks, an improvement in #162 and the use of the health checks in #154, we should use the health checks in as many test containers as possible, to benefit from the mechanism and reduce build time in CI.

This PR adds health checks for Consul and Memcached.

As their images don't have the necessary tooling installed by default, and we don't want to execute the main server process as root, we instead run a separate docker exec command to install the required tooling, while the health checks are already running (but running into errors like "curl not found").

@philippgille philippgille marked this pull request as ready for review January 10, 2024 20:24
@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (128881d) 63.64% compared to head (b6e6e82) 63.64%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #168   +/-   ##
=======================================
  Coverage   63.64%   63.64%           
=======================================
  Files          25       25           
  Lines        2107     2107           
=======================================
  Hits         1341     1341           
  Misses        651      651           
  Partials      115      115           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippgille philippgille merged commit cb88eb2 into master Jan 21, 2024
8 checks passed
@philippgille philippgille deleted the add-docker-health-checks-to-consul-memcached branch January 21, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants