Gitignore fixtures and dist/commonjs. #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philschatz
added a commit
that referenced
this pull request
Jul 10, 2014
Gitignore fixtures and dist/commonjs.
sanemat
added a commit
to sanemat/octokat.js
that referenced
this pull request
Aug 22, 2015
related: ReferenceError: Can't find variable: Mocha when running test Issue philschatz#7 nathanboktae/mocha-phantomjs-core nathanboktae/mocha-phantomjs-core#7
sanemat
added a commit
to sanemat/octokat.js
that referenced
this pull request
Aug 22, 2015
related: ReferenceError: Can't find variable: Mocha when running test Issue philschatz#7 nathanboktae/mocha-phantomjs-core nathanboktae/mocha-phantomjs-core#7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1.
Gitignores:
dist/octokat.jsneeds to be Git tracked for bower, while the CommonJS targets NPM Nodejs users.This requires the addition of a
.npmignoreso that NPM won't use the.gitignorewhich would ignoredist/commonjs/.package.jsonis never ignored, so*works.Tested locally with
npm install -g .and worked.