Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #3

Merged
merged 1 commit into from
Oct 26, 2021
Merged

Update README.md #3

merged 1 commit into from
Oct 26, 2021

Conversation

panwauu
Copy link
Contributor

@panwauu panwauu commented Oct 26, 2021

Hi,
I found your library before seeing that Socket.io includes typed events in 4.x.
Sadly this is hidden deep in the docs there.
It would be nice if you could add a note to the readme regarding this.
Best,
Oskar

@phiresky
Copy link
Owner

Thanks. I saw the update, but I didn't investigate how complete the support is and in what ways it actually fully replaces this library. I'll merge this and add a sentence or two more.

(for reference, their original PR: socketio/socket.io#3822 )

@phiresky phiresky merged commit d01bb80 into phiresky:master Oct 26, 2021
@panwauu panwauu deleted the patch-1 branch October 26, 2021 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants