Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we rename the ISA composite dataset #16

Closed
pkrog opened this issue Oct 24, 2017 · 3 comments
Closed

Can we rename the ISA composite dataset #16

pkrog opened this issue Oct 24, 2017 · 3 comments
Assignees

Comments

@pkrog
Copy link
Member

pkrog commented Oct 24, 2017

Try to change the default of the uploaded ISA composite dataset ("Uploaded Composite Dataset (isa)") to the name of the uploaded zip file or the title or identifier of the investigation, or the identifier of the study.

@pkrog pkrog self-assigned this Oct 24, 2017
pkrog pushed a commit that referenced this issue Nov 13, 2017
/learn/advanced-workflow/variables-edit
@kikkomep
Copy link
Member

Usually, the dataset name coincides with the short name of its datatype (e.g., zip, txt, etc.).
To set the short name we need to add a proper metadata attribute to the class which implements the dataset datatype as in fix/isa-datatype-rename-dataset.

To dynamically define a dataset name using the dataset content we need to patch the post processing phase of the Galaxy JobWrapper.

@kikkomep kikkomep self-assigned this Nov 13, 2017
@pkrog
Copy link
Member Author

pkrog commented Jan 8, 2018

I've done it using a hack that I don't understand, so it can be perfected...
What needs to be done also is to not rely only on the ISA identifier for the dataset name, since it could not exist. Use the filename in case no identifier is defined, and set a constant name like "ISA dataset" as default.

@pkrog
Copy link
Member Author

pkrog commented Jan 12, 2018

Done

@pkrog pkrog closed this as completed Jan 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants