kernel/vm: Make some functions static and remove dead code #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
niewim19
previously approved these changes
May 20, 2024
agkaminski
reviewed
May 20, 2024
niewim19
reviewed
May 20, 2024
agkaminski
previously approved these changes
May 21, 2024
|
@damianloew is this PR`s CI able to be repaired by rerunning campaign? Or do we hold it as error case? |
Re-run should help, I've already done it :) |
niewim19
previously approved these changes
May 24, 2024
Darchiv
reviewed
May 24, 2024
- Remove unreachable function `vm_pageFreeAt` - Merge `_page_free` and `vm_pageFree` Fixes: phoenix-rtos/phoenix-rtos-project#1080 Fixes: phoenix-rtos/phoenix-rtos-project#1082 JIRA: RTOS-836
Darchiv
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
_page_mapand_page_initSizesstatic_page_showSizesFixes: phoenix-rtos/phoenix-rtos-project#1071
Fixes: phoenix-rtos/phoenix-rtos-project#1072
Fixes: phoenix-rtos/phoenix-rtos-project#1073
Fixes: phoenix-rtos/phoenix-rtos-project#1080
Fixes: phoenix-rtos/phoenix-rtos-project#1082
JIRA: RTOS-836
Motivation and Context
Types of changes
How Has This Been Tested?
Checklist:
Special treatment