Agg vs gold fixes #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes #49 |
|
This now tests gold standard vs. the aggregation RData output with all of the ISO code fixes in place (i.e., it behaves as if this PR and #68 have both been merged already). With those ISO code fixes in place, the agg vs. gold disparity is down to 4 languages present in gold but not in agg, and 15 inventories with discrepancies between agg & gold. |
…agg-vs-gold-fixes
alleged glottal tap -> glottal stop. closes phoible#83
fix: representation of clicks in nmn from GM
…easier rebasing of agg-vs-gold-fixes branch. This reverts commit 701ff69.
…agg-vs-gold-fixes. pull from origin after rebase against upstream master.
|
@bambooforest, it's probably time to merge this before things get any more tangled. There are still a few agg vs gold differences, but they'll be easier to see once this is merged and I can look at it afresh. |
|
I agree. Will review and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a test script to compare the "gold standard" database dump with the output of the aggregation script, and fixes some of the problems that it reveals (though not yet all). Should not be merged yet, until we figure out what to do about the remaning discrepancies between
aggandgold. Note that most of the remaining discrepancies are due to the UPSID "dental|alveolar" agnosticism.You can test this locally with
git checkout -b testAggGold drammock/agg-vs-gold-fixes(assuming you have a remote called
drammockthat points todrammock/phoiblerepo).