Removed '[DEBUG] ' prefix from output #42

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants

rodhan commented Mar 22, 2013

Removed '[DEBUG] ' prefix so that ios-sim correctly passes through output that can be parsed correctly by other tools, for example, the Jenkins/Hudson Xcode integration plugin.

rodhan added some commits Mar 22, 2013

Don't return a failure exit code if the simulator session ends with a…
…n error, even if the error is not nil. Fixes issue #42: "Unit tests pass but ios-sim exits with an error code of 1"
Owner

shazron commented Mar 22, 2013

Thanks rodhan, can you send commit 2dca9a4 separately for discussion? I don't think it's the correct approach - did you see pull request #43? I can pull in commit c5b759e, re-submit with only that (in the future each pull request should be a separate fix/feature). Thanks!

rodhan commented Mar 22, 2013

After looking into this a bit more I was a bit premature with the pull request for 2dca9a4 - I agree that it isn't the right approach. I misunderstood what was going on - I didn't realise that session:didEndWithError: was called after every session, I thought from the method name that the simulator was always exiting with an error but sometimes wasn't setting the error parameter.

I think it would be good to check for the specific "The simulated application quit." NSError and not return failure in that case but otherwise fail if there is any other error. The other changes in pull request #43 go a bit too far for my purposes though.

I have resubmitted c5b759e separately as you suggested as pull request #44. Thanks for your help.

@rodhan rodhan closed this Mar 22, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment