Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove docker image from CircleCI config #256

Merged
1 commit merged into from
Dec 9, 2019

Conversation

thinkh
Copy link
Contributor

@thinkh thinkh commented Dec 3, 2019

Closes #255

Developer Checklist (Definition of Done)

  • Descriptive title for this pull request provided (will be used for release notes later)
  • All acceptance criteria from the issue are met
  • Branch is up-to-date with the branch to be merged with, i.e., develop
  • Code is cleaned up and formatted
  • Code documentation written
  • Unit tests written
  • Build is successful
  • Summary of changes written
  • Wiki documentation written
  • Assign at least one reviewer
  • Assign at least one assignee
  • Add type label (e.g., bug, enhancement) to this pull request
  • Add next version label (e.g., release: minor) to this PR following semver

Summary of changes

  • Remove unnecessary Docker image from CircleCI config

@thinkh thinkh added type: technical-debt Describes or removes a technical debt type: deployment Issues regarding the deployment release: patch PR merge results in a new patch version labels Dec 3, 2019
@thinkh thinkh requested a review from a user December 3, 2019 09:48
@thinkh thinkh assigned ghost Dec 3, 2019
@thinkh
Copy link
Contributor Author

thinkh commented Dec 3, 2019

@anita-steiner Should we switch to a specific Docker version (see https://circleci.com/docs/2.0/building-docker-images/#docker-version)? If yes, which? Previously we had 17.05.0-ce-git, CircleCI default is 17.09.0-ce. The 17.09.0-ce does work (tested in ordino_product). The question is if we want to update to a higher version?

@ghost ghost merged commit f43485a into develop Dec 9, 2019
@ghost ghost deleted the thinkh/255_remove-docker-image-from-product branch December 9, 2019 08:50
@thinkh thinkh mentioned this pull request Dec 10, 2019
21 tasks
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: patch PR merge results in a new patch version type: deployment Issues regarding the deployment type: technical-debt Describes or removes a technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant