Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change css filename from style to [name] in webpack.config.js #258

Merged
1 commit merged into from
Dec 9, 2019
Merged

Change css filename from style to [name] in webpack.config.js #258

1 commit merged into from
Dec 9, 2019

Conversation

thinkh
Copy link
Contributor

@thinkh thinkh commented Dec 3, 2019 •
edited
Loading

Closes #257

Developer Checklist (Definition of Done)

  • Descriptive title for this pull request provided (will be used for release notes later)
  • All acceptance criteria from the issue are met
  • Branch is up-to-date with the branch to be merged with, i.e., develop
  • Code is cleaned up and formatted
  • Code documentation written
  • Unit tests written
  • Build is successful
  • Summary of changes written
  • Wiki documentation written
  • Assign at least one reviewer
  • Assign at least one assignee
  • Add type label (e.g., bug, enhancement) to this pull request
  • Add next version label (e.g., release: minor) to this PR following semver

Summary of changes

  • Change css filename from style to [name] in webpack.config.js

@thinkh thinkh added type: technical-debt Describes or removes a technical debt release: patch PR merge results in a new patch version labels Dec 3, 2019
@thinkh thinkh requested a review from a user December 3, 2019 11:50
@thinkh thinkh assigned ghost Dec 3, 2019
ghost
ghost reviewed Dec 3, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thinkh where do we set the placeholder [name]

@thinkh
Copy link
Contributor Author

thinkh commented Dec 3, 2019

@anita-steiner That is a variable of the ExtractTextWebpackPlugin. See https://webpack.js.org/plugins/extract-text-webpack-plugin/#options

@ghost ghost merged commit 46ec89b into develop Dec 9, 2019
@thinkh thinkh mentioned this pull request Dec 10, 2019
Merged
21 tasks
@thinkh thinkh deleted the thinkh/257_css-bundle-name-variable branch December 17, 2019 15:43
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
release: patch PR merge results in a new patch version type: technical-debt Describes or removes a technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thinkh