Advanced examples #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r starting with php
…t a fork, isn't empty, and has a .travis.yml
stickler-ci
reviewed
Nov 6, 2017
examples/resolve_travis-key.php
Outdated
| $keyFile = dirname(__DIR__) . DIRECTORY_SEPARATOR . 'travis-key.php'; | ||
|
|
||
| if (!file_exists($keyFile)) { | ||
| echo 'No key file find, copy key.sample.php to key.php and add access token from https://blog.travis-ci.com/2013-01-28-token-token-token/ to run examples.', PHP_EOL; |
There was a problem hiding this comment.
Line exceeds 120 characters; contains 169 characters
stickler-ci
reviewed
Dec 7, 2017
| ]); | ||
|
|
||
| // Fetch the user/org given as first argument to this script | ||
| $baseStream = unwrapObservableFromPromise($githubClient->user($argv[1])->then(function (UserInterface $user) use ($argv) { |
There was a problem hiding this comment.
Line exceeds 120 characters; contains 122 characters
examples/resolve_appveyor-key.php
Outdated
| $keyFile = dirname(__DIR__) . DIRECTORY_SEPARATOR . 'appveyor-key.php'; | ||
|
|
||
| if (!file_exists($keyFile)) { | ||
| echo 'No key file found, copy key.sample.php to key.php and add API token from https://ci.appveyor.com/api-token to run examples.', PHP_EOL; |
There was a problem hiding this comment.
Line exceeds 120 characters; contains 144 characters
| return new Promise(function ($resolve, $reject) use ($command) { | ||
| $repo = false; | ||
| $this->appveyor->projects()->filter(function (ProjectInterface $project) use ($command) { | ||
| return $project->repositoryType() === 'github' && $project->repositoryName() === $command->getRepository(); |
There was a problem hiding this comment.
Line exceeds 120 characters; contains 123 characters
stickler-ci
reviewed
Dec 7, 2017
|
|
||
| // Fetch the user/org given as first argument to this script | ||
| $baseStream = unwrapObservableFromPromise( | ||
| $githubClient->user($argv[1] |
There was a problem hiding this comment.
Expected 0 spaces before closing bracket; newline found
| // Fetch the user/org given as first argument to this script | ||
| $baseStream = unwrapObservableFromPromise( | ||
| $githubClient->user($argv[1] | ||
| )->then(function (UserInterface $user) use ($argv) { |
There was a problem hiding this comment.
Multi-line function call not indented correctly; expected 4 spaces but found 0
|
|
||
| // Get all repositories for the given user | ||
| return $user->repositories(); | ||
| }))->filter(function (Repository $repository) { |
There was a problem hiding this comment.
Closing parenthesis of a multi-line function call must be on a line by itself
… clients to require-dev and suggest because the user might not need them
stickler-ci
reviewed
Dec 23, 2017
| $keyFile = dirname(__DIR__) . DIRECTORY_SEPARATOR . 'scrutinizer-token.php'; | ||
|
|
||
| if (!file_exists($keyFile)) { | ||
| echo 'No key file find, copy token.sample.php to token.php and add a token from https://scrutinizer-ci.com/profile/applications to run examples.', PHP_EOL; |
There was a problem hiding this comment.
Line exceeds 120 characters; contains 159 characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.