Added Cluster Support #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stickler-ci
reviewed
Nov 6, 2017
| @@ -83,7 +83,7 @@ public function __construct(Subject $client) | |||
| * @throws \InvalidArgumentException | |||
| * @return AsyncClient | |||
| */ | |||
| public static function create(LoopInterface $loop, string $app, Resolver $resolver = null): AsyncClient | |||
| public static function create(LoopInterface $loop, string $app, Resolver $resolver = null, $cluster = null): AsyncClient | |||
There was a problem hiding this comment.
Line exceeds 120 characters; contains 124 characters
| @@ -43,5 +43,9 @@ public function testCreateUrl() | |||
| $expectedUrl = 'wss://ws.pusherapp.com/app/barBaz?client=api-clients%2Fpusher+%28https%3A%2F%2Fphp-api-clients.org%2Fclients%2Fpusher%29&protocol=7&version=' . ApiSettings::getVersion(); | |||
|
|
|||
| self::assertSame($expectedUrl, ApiSettings::createUrl('barBaz')); | |||
|
|
|||
| $expectedUrl = 'wss://ws-ap1.pusher.com/app/barBaz?client=api-clients%2Fpusher+%28https%3A%2F%2Fphp-api-clients.org%2Fclients%2Fpusher%29&protocol=7&version=' . ApiSettings::getVersion(); | |||
There was a problem hiding this comment.
Line exceeds 120 characters; contains 195 characters
|
|
||
| $expectedUrl = 'wss://ws-ap1.pusher.com/app/barBaz?client=api-clients%2Fpusher+%28https%3A%2F%2Fphp-api-clients.org%2Fclients%2Fpusher%29&protocol=7&version=' . ApiSettings::getVersion(); | ||
|
|
||
| self::assertSame($expectedUrl, ApiSettings::createUrl('barBaz','ap1')); |
There was a problem hiding this comment.
No space found after comma in function call
|
Sweet thanks 👍 ! I'll tag a new release with this feature later today 🎉 |
|
Thanks again, version |
|
Thanks mate :) |
|
No problem, also do you have twitter? Going to tweet about the release tomorrow and would like to thank you in it :). |
|
I'm afraid it's too late but is @robsonvn 😂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.