Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When not returning a promise, done() should be used to not swallow exceptions thrown inside the callbacks.
Also, done() does not create unused child promises, saving a bit of resources.
Passing
$promise
throughresolve()
makes extra sure we're working onExtendedPromiseInterface
. Theoretically, this could be ommitted since all promises from react/promise implementingPromiseInterface
also implementExtendedPromiseInterface
(applies to react/promise 2.x).