Improve pusher integration #9

WyriHaximus · 2017-02-11T21:58:10Z

Move to command bus handler
Test Handler

…dlers

This commit consists of patches automatically generated for this project on https://scrutinizer-ci.com

Scrutinizer Auto-Fixes

# Conflicts: # composer.lock

stickler-ci · 2017-04-19T15:46:49Z

src/CommandBus/Handler/BroadcastsHandler.php

@@ -33,6 +32,6 @@ public function __construct(FetchAndIterateService $fetchAndIterateService)
     */
    public function handle(BroadcastsCommand $command): PromiseInterface
    {
-        return $this->fetchAndIterateService->handle('broadcasts', 'broadcasts', BroadcastInterface::HYDRATE_CLASS);
+        return resolve($this->fetchAndIterateService->iterate('broadcasts', 'broadcasts', BroadcastInterface::HYDRATE_CLASS));


Line exceeds 120 characters; contains 126 characters

stickler-ci · 2017-04-19T15:46:49Z

tests/CommandBus/Handler/RepositoryHandlerTest.php

-            Argument::exact($json)
-        )->shouldBeCalled()->willReturn($repositoryResource);
+        $service = $this->prophesize(FetchAndHydrateService::class);
+        $service->fetch('repos/wyrihaximus/tactician-command-handler-mapper', 'repo', RepositoryInterface::HYDRATE_CLASS)->shouldBeCalled()->willReturn(resolve($repositoryResource));


Line exceeds 120 characters; contains 182 characters

stickler-ci · 2017-04-19T15:46:50Z

tests/CommandBus/Handler/RepositoryHandlerTest.php

-
-        $requestService = new RequestService($client->reveal());
+        $service = $this->prophesize(FetchAndHydrateService::class);
+        $service->fetch('repos/wyrihaximus/tactician-command-handler-mapper', 'repo', RepositoryInterface::HYDRATE_CLASS)->shouldBeCalled()->willReturn(resolve($repositoryResource));


Line exceeds 120 characters; contains 182 characters

stickler-ci · 2017-04-19T15:46:50Z

tests/CommandBus/Handler/RepositoryHandlerTest.php

-            Argument::type('array')
-        )->shouldBeCalled()->willReturn(reject(
+        $service = $this->prophesize(FetchAndHydrateService::class);
+        $service->fetch('repos/wyrihaximus/tactician-command-handler-mapper', 'repo', RepositoryInterface::HYDRATE_CLASS)->shouldBeCalled()->willReturn(reject(


Line exceeds 120 characters; contains 159 characters

stickler-ci · 2017-04-19T15:46:51Z

tests/CommandBus/Handler/RepositoryKeyHandlerTest.php

-            Argument::exact($json)
-        )->shouldBeCalled()->willReturn($repositoryResource);
+        $service = $this->prophesize(FetchAndHydrateService::class);
+        $service->fetch('repos/wyrihaximus/tactician-command-handler-mapper/key', '', RepositoryKeyInterface::HYDRATE_CLASS)->shouldBeCalled()->willReturn(resolve($repositoryResource));


Line exceeds 120 characters; contains 185 characters

stickler-ci · 2017-04-19T15:46:51Z

tests/CommandBus/Handler/SSHKeyHandlerTest.php

-            )
-        ));
+        $service = $this->prophesize(FetchAndHydrateService::class);
+        $service->fetch('settings/ssh_key/123', 'ssh_key', SSHKeyInterface::HYDRATE_CLASS)->shouldBeCalled()->willReturn(resolve($sshKeyResource));


Line exceeds 120 characters; contains 147 characters

stickler-ci · 2017-04-19T15:46:51Z

tests/CommandBus/Handler/UserHandlerTest.php


-        $requestService = new RequestService($client->reveal());
+        $service = $this->prophesize(FetchAndHydrateService::class);
+        $service->fetch('users', 'user', UserInterface::HYDRATE_CLASS)->shouldBeCalled()->willReturn(resolve($userResource));


Line exceeds 120 characters; contains 125 characters

stickler-ci · 2017-04-20T21:11:25Z

tests/ClientTest.php

@@ -114,7 +112,7 @@ public function testObservableMethods(string $method, string $resourceInterface,

        $loop = Factory::create();
        $asyncClient = $this->prophesize(AsyncClientInterface::class);
-        $asyncClient->$method()->shouldBeCalled()->willReturn(Observable::fromArray($resources));
+        $asyncClient->$method()->shouldBeCalled()->willReturn(Observable::fromArray($resources, new ImmediateScheduler()));


Line exceeds 120 characters; contains 123 characters

stickler-ci · 2017-04-20T21:11:25Z

tests/ClientTest.php

@@ -129,7 +127,7 @@ public function testRepositories()

        $loop = Factory::create();
        $asyncClient = $this->prophesize(AsyncClientInterface::class);
-        $asyncClient->repositories(null)->shouldBeCalled()->willReturn(Observable::fromArray($resources));
+        $asyncClient->repositories(null)->shouldBeCalled()->willReturn(Observable::fromArray($resources, new ImmediateScheduler()));


Line exceeds 120 characters; contains 132 characters

stickler-ci · 2017-04-20T21:11:25Z

tests/ClientTest.php

@@ -148,7 +146,7 @@ public function testRepositoriesFilter()

        $loop = Factory::create();
        $asyncClient = $this->prophesize(AsyncClientInterface::class);
-        $asyncClient->repositories($func)->shouldBeCalled()->willReturn(Observable::fromArray($resources));
+        $asyncClient->repositories($func)->shouldBeCalled()->willReturn(Observable::fromArray($resources, new ImmediateScheduler()));


Line exceeds 120 characters; contains 133 characters

WyriHaximus and others added 19 commits February 9, 2017 08:11

No need to run with sudo false for cache, also only cache composer files

2b81a37

Updated pusher client and moved pusher related logic into command han…

7363bb4

…dlers

Corrected expected return type

e560551

Line length

27bc2c2

Removed unused use statements

cb8ebe8

Updated test utilities

049a17b

Corrected $id type in docblock

436c437

Corrected $id dockblock type

debcc78

Scrutinizer Auto-Fixes

15833d3

This commit consists of patches automatically generated for this project on https://scrutinizer-ci.com

Merge pull request #10 from php-api-clients/scrutinizer-patch-1

bda3c51

Scrutinizer Auto-Fixes

Merge branch 'master' into improve-pusher

1ee0089

Merge remote-tracking branch 'origin/improve-pusher' into improve-pusher

79f8544

Dispose of subscription once the final line has been reached

ca69311

Updated dependencies

c9ae475

Merge branch 'master' into improve-pusher

3923bb2

# Conflicts: # composer.lock

Resolved merge conflicts using composer update

17c94d0

Latest tagged packages

146e40d

Merge branch 'master' into improve-pusher

366ef4b

# Conflicts: # composer.lock

Updated dependencies and update handlers to the changed services

8c9b610

stickler-ci reviewed Apr 19, 2017

View reviewed changes

WyriHaximus added 3 commits April 19, 2017 21:04

Line length

d6296a0

Set async scheduler factory (temporary)

4bf8c70

Use ImmediateScheduler for from array observables

ee7e737

stickler-ci reviewed Apr 20, 2017

View reviewed changes

WyriHaximus merged commit c0537bc into master Apr 24, 2017

WyriHaximus deleted the improve-pusher branch April 24, 2017 19:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Improve pusher integration #9

Improve pusher integration #9

Uh oh!

WyriHaximus commented Feb 11, 2017

Uh oh!

stickler-ci Apr 19, 2017

Uh oh!

stickler-ci Apr 19, 2017

Uh oh!

stickler-ci Apr 19, 2017

Uh oh!

stickler-ci Apr 19, 2017

Uh oh!

stickler-ci Apr 19, 2017

Uh oh!

stickler-ci Apr 19, 2017

Uh oh!

stickler-ci Apr 19, 2017

Uh oh!

stickler-ci Apr 20, 2017

Uh oh!

stickler-ci Apr 20, 2017

Uh oh!

stickler-ci Apr 20, 2017

Uh oh!

Uh oh!

Improve pusher integration #9

Improve pusher integration #9

Uh oh!

Conversation

WyriHaximus commented Feb 11, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!