Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement remote fetching of the model.conf #16

Conversation

francoisauclair911
Copy link

  • Require Guzzle
  • Added to config key for url path and cache time
  • Added logic to fetch the .conf file and use it as a model.

@francoisauclair911 francoisauclair911 changed the title Implements remote fetching of the model.conf feat: implement remote fetching of the model.conf Mar 31, 2021
@hsluoyz
Copy link
Member

hsluoyz commented Apr 1, 2021

Fix: #15

@hsluoyz
Copy link
Member

hsluoyz commented Apr 1, 2021

@techoner

Copy link
Member

@leeqvip leeqvip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@francoisauclair911 These changes should not cause the entire file to be modified, as well as the modification of blank lines, please modify the git configuration and recommit .

@francoisauclair911
Copy link
Author

Fighting my IDE at every step but I'll finally merge the right thing

@francoisauclair911
Copy link
Author

@techoner hopefully this works now ?
Not sure how clean it looks, I can delete this and recreate new merge request if it helps

Cheers

@hsluoyz
Copy link
Member

hsluoyz commented Apr 2, 2021

@francoisauclair911 plz squash your commits into one single commit.

And also fix the checks:

image

@leeqvip
Copy link
Member

leeqvip commented Apr 6, 2021

@techoner hopefully this works now ?
Not sure how clean it looks, I can delete this and recreate new merge request if it helps

Cheers

@francoisauclair911 .gitconfig should ignore newlines and file mods

[core]
autocrlf = false
filemode = false
safecrlf = true

@francoisauclair911 francoisauclair911 force-pushed the feature/remote-fetching-model branch 4 times, most recently from cd962c9 to 6ca5f6f Compare April 29, 2021 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants