feat: support updateFilteredPolicies method #29
Merged
+176
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@techoner |
leeqvip
requested changes
Aug 29, 2021
| // ]; | ||
| // $this->assertEqualsCanonicalizing(Enforcer::getPolicy(), $policies); | ||
| } | ||
|
|
There was a problem hiding this comment.
Why is it commented out this code? @basakest
There was a problem hiding this comment.
This method calls some methods in php-casbin, and the pr has not been merged before @techoner
basakest
force-pushed
the
updateFilteredPolicies
branch
3 times, most recently
from
3834efe to
aca58aa
Compare
feat: support updateFilteredPolicies method feat: support updateFilteredPolicies method feat: support updateFilteredPolicies method feat: support updateFilteredPolicies method
basakest
force-pushed
the
updateFilteredPolicies
branch
from
aca58aa to
0e1eef3
Compare
leeqvip
approved these changes
Sep 2, 2021
| // ]; | ||
| // $this->assertEqualsCanonicalizing(Enforcer::getPolicy(), $policies); | ||
| } | ||
|
|
| } | ||
| if ($fieldIndex <= 5 && 5 < $fieldIndex + count($fieldValues)) { | ||
| $where['v5'] = $fieldValues[5 - $fieldIndex]; | ||
| } |
There was a problem hiding this comment.
@basakest I think this is not complete enough, empty("" or null) values are not excluded .
|
|
||
| Enforcer::updateFilteredPolicies([["alice", "data1", "write"]], 0, "alice", "data1", "read"); | ||
| Enforcer::updateFilteredPolicies([["bob", "data2", "read"]], 0, "bob", "data2", "write"); | ||
|
|
There was a problem hiding this comment.
The test case can be more comprehensive, such as:
- Update all policies of
alice - Replace all policies of
aliceondata - Update all
writepolicies ofalice - Update
data1, onlybobcanwrite
and many more...
|
🎉 This PR is included in version 2.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #30