feat: add GetImplicitUsersForResource and GetAllowedObjectConditions APIs etc.
#156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 10439810437Details
💛 - Coveralls |
Dobmod
force-pushed
the
feature-more-api-1.0
branch
from
5ecb589 to
535d0fd
Compare
leeqvip
requested changes
Aug 18, 2024
src/Enforcer.php
Outdated
Comment on lines
534
to
543
|
|
||
| $trimPrefix = function ($string, $prefix) { | ||
| if (strpos($string, $prefix) === 0) { | ||
| return substr($string, strlen($prefix)); | ||
| } else { | ||
| return $string; | ||
| } | ||
| }; | ||
|
|
||
| $objectConditions[] = $trimPrefix($policy[1], $prefix); |
There was a problem hiding this comment.
Please simplify this code
Suggested change
| $trimPrefix = function ($string, $prefix) { | |
| if (strpos($string, $prefix) === 0) { | |
| return substr($string, strlen($prefix)); | |
| } else { | |
| return $string; | |
| } | |
| }; | |
| $objectConditions[] = $trimPrefix($policy[1], $prefix); | |
| $objectConditions[] = substr($policy[1], strlen($prefix); |
src/Enforcer.php
Outdated
Comment on lines
579
to
573
| foreach ($roles as $role) { | ||
| $isRole[$role] = true; | ||
| } |
There was a problem hiding this comment.
Please simplify this code:
Suggested change
| foreach ($roles as $role) { | |
| $isRole[$role] = true; | |
| } | |
| $isRole = array_flip($rules); |
src/Enforcer.php
Outdated
| * | ||
| * @return array | ||
| */ | ||
| public function removeDumplicatePermissions(array $permissions): array |
There was a problem hiding this comment.
Please define it as a private function.
Dobmod
force-pushed
the
feature-more-api-1.0
branch
2 times, most recently
from
bb66a6f to
4762fd6
Compare
Dobmod
force-pushed
the
feature-more-api-1.0
branch
from
4762fd6 to
1a1e389
Compare
|
I made changes, please review. |
leeqvip
reviewed
Aug 18, 2024
leeqvip
approved these changes
Aug 18, 2024
|
🎉 This issue has been resolved in version 3.24.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetImplicitUsersForResource,GetAllowedObjectConditions,GetAllDomains,GetAllRolesByDomainto RBAC APIGetDomains,GetAllDomainsto RoleManager APIObjConditionExceptionandEmptyConditionException