phpunit detects more clearly if coverage output was successfully #355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corpsee
reviewed
Mar 19, 2020
src/Plugin/PhpUnit.php
Outdated
|
|
||
| if ($fileSystem->exists($this->buildLocation) && | ||
| if ($fileSystem->exists($this->buildLocation.'.index.html') && |
There was a problem hiding this comment.
@SimonHeimberg I guess it should be $fileSystem->exists($this->buildLocation . '/index.html')
There was a problem hiding this comment.
Verry likely, yes. Strange, why did I not see this? I run my system like this since a longer time...
according to review by @corpsee
|
@SimonHeimberg Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution type
improvement
Description of change
phpunit checks output file generated by coverage instead of directory.
It reports clearly when the report was not created successfully.