Exercise 1 and 2 Code Files #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Sep 13, 2019
| use UserAccountSchema; | ||
|
|
||
| /** string */ | ||
| public const SUBSCRIPTION_TYPE_MONTHLY = 'monthly'; |
ghost
reviewed
Sep 13, 2019
| * | ||
| * @return mixed[] | ||
| */ | ||
| protected function doToArray(): array |
ghost
reviewed
Sep 13, 2019
| * | ||
| * @return \App\External\Libraries\Auth | ||
| */ | ||
| public function setApiKey(?ApiKey $apiKey = null): self |
ghost
reviewed
Sep 13, 2019
| /** | ||
| * @covers \App\Database\Entities\UserAccount | ||
| */ | ||
| final class UserAccountTest extends DoctrineAnnotationsTestCase |
buddyshontogan
force-pushed
the
loyalty/buddy
branch
from
344f179 to
f30c2bc
Compare
- Exercise 1 and 2 code
albertlabarentojr
requested changes
Sep 15, 2019
| @@ -4,6 +4,7 @@ | |||
| namespace App\Database\Entities; | |||
|
|
|||
| use App\Database\Schema\UserSchema; | |||
|
|
|||
There was a problem hiding this comment.
Kindly remove this line :)
|
|
||
| /** string */ | ||
| public const SUBSCRIPTION_TYPE_LIFETIME = 'lifetime'; | ||
| public const SUBSCRIPTION_TYPE_MONTHLY = 'monthly'; |
There was a problem hiding this comment.
Kindly annotate as string
| { | ||
|
|
||
| /** string */ | ||
| public const SUBSCRIPTION_TYPE_LIFETIME = 'lifetime'; |
There was a problem hiding this comment.
No need for this constants here you may reuse from UserAccount
| */ | ||
| protected function getIdProperty(): string | ||
| { | ||
| return 'userAcctId'; |
There was a problem hiding this comment.
Kindly rename userAcctId to accountId, user and account doesn't have any relationship yet. a user may have multiple accounts or vice versa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exercise 1 and Exercise 2 files