Skip to content

silence PHP 8.1 deprecations #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 27, 2021
Merged

silence PHP 8.1 deprecations #691

merged 2 commits into from
Nov 27, 2021

Conversation

3kbest
Copy link
Contributor

@3kbest 3kbest commented Nov 24, 2021

Add ReturnTypeWillChange attribute to silence PHP 8.1 deprecations

zachborboa
zachborboa reviewed Nov 25, 2021
View reviewed changes
zachborboa
zachborboa requested changes Nov 25, 2021
View reviewed changes
Copy link
Member

@zachborboa zachborboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use ReturnTypeWillChange; should be removed, but otherwise LGTM

@zachborboa zachborboa mentioned this pull request Nov 25, 2021
Closed
@3kbest 3kbest requested a review from zachborboa November 27, 2021 22:50
@zachborboa zachborboa merged commit f73b978 into php-curl-class:master Nov 27, 2021
@zachborboa
Copy link
Member

Thanks!

@zachborboa zachborboa mentioned this pull request Dec 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachborboa zachborboa zachborboa approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@3kbest @zachborboa