Skip to content

Continues code alignment with PhpDb 0.0.1. #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: x.x.1
Choose a base branch
from
Open

Continues code alignment with PhpDb 0.0.1. #6

wants to merge 9 commits into from

Conversation

tyrsson
Copy link
Member

@tyrsson tyrsson commented Jul 16, 2025 •
edited
Loading

This PR continues the work to align the code with current usage in PhpDb.

  • Provides Factories for required services.
  • Refactors the Connection class
  • Connection Parameters have been reduced to dsn, charset, options.

@tyrsson
Continues code alignment with PhpDb 0.0.1 alignment.
4ccb705 
Signed-off-by: Joey Smith <jsmith@webinertia.net>

Signed-off-by: Joey Smith <jsmith@webinertia.net>
@tyrsson tyrsson requested review from settermjd and simon-mundy July 16, 2025 05:35
@tyrsson tyrsson self-assigned this Jul 16, 2025
@tyrsson tyrsson added this to @phpdb Jul 16, 2025
@github-project-automation github-project-automation bot moved this to Todo in @phpdb Jul 16, 2025
@tyrsson tyrsson changed the title Continues code alignment with PhpDb 0.0.1 alignment. Continues code alignment with PhpDb 0.0.1. Jul 16, 2025
@tyrsson tyrsson added this to the 0.0.1 milestone Jul 16, 2025
tyrsson added 2 commits July 17, 2025 00:25
@tyrsson
Semi working code. Adapter initializes and will write data to sqlite.
7f3803f 
Signed-off-by: Joey Smith <jsmith@webinertia.net>

Signed-off-by: Joey Smith <jsmith@webinertia.net>
@tyrsson
closes php-db#7
1183232 
Signed-off-by: Joey Smith <jsmith@webinertia.net>

Signed-off-by: Joey Smith <jsmith@webinertia.net>
@tyrsson tyrsson linked an issue Jul 20, 2025 that may be closed by this pull request
Connection::getCurrentSchema #7
Open
tyrsson added 3 commits July 20, 2025 02:34
@tyrsson
Fixes PHPUnit config so test will run
2eb6f47 
Starts work to fix unit and integration test
Signed-off-by: Joey Smith <jsmith@webinertia.net>

Signed-off-by: Joey Smith <jsmith@webinertia.net>
@tyrsson
enable github actions
6ca6775 
Signed-off-by: Joey Smith <jsmith@webinertia.net>

Signed-off-by: Joey Smith <jsmith@webinertia.net>
@tyrsson
Signed-off-by: Joey Smith <jsmith@webinertia.net>
a778988
@tyrsson tyrsson linked an issue Jul 22, 2025 that may be closed by this pull request
Failing integration test #8
Open
@tyrsson
Fixes integration test for the moment.
75cb1bf 
Signed-off-by: Joey Smith <jsmith@webinertia.net>

Signed-off-by: Joey Smith <jsmith@webinertia.net>
@tyrsson tyrsson linked an issue Jul 22, 2025 that may be closed by this pull request
Coding Standards #10
Open
tyrsson added 2 commits July 24, 2025 02:00
@tyrsson
Continues work to fix unit test
a0c86a7 
Signed-off-by: Joey Smith <jsmith@webinertia.net>

Signed-off-by: Joey Smith <jsmith@webinertia.net>
@tyrsson
stash latest revisions
3ab93e6 
Signed-off-by: Joey Smith <jsmith@webinertia.net>

Signed-off-by: Joey Smith <jsmith@webinertia.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@settermjd settermjd Awaiting requested review from settermjd

@simon-mundy simon-mundy Awaiting requested review from simon-mundy

At least 1 approving review is required to merge this pull request.

Assignees

@tyrsson tyrsson

Labels
db: SQLite enhancement New feature or request New Feature priority: Critical
Projects
@phpdb
Status: Todo
Milestone
0.0.1
Development

Successfully merging this pull request may close these issues.

Coding Standards Failing integration test Connection::getCurrentSchema
1 participant
@tyrsson