[RFC]: Adapter\Driver\Feature

[tyrsson]

Proposed Version

3.0.0

Basic Information

In the current implementation we have the following:

• DriverFeatureInterface
• AbstractFeature

Background

One of the overall goals is to have all packages built to the interfaces.

Considerations

This will effect all Pdo concrete drivers.

Proposal(s)

Replace the existing implementation with:

• DriverFeatureProviderInterface
• DriverFeatureInterface
• AbstractFeature

Resulting in:

• AbstractFeature would then implement DriverFeatureInterface.
• Contractual methods would move from DriverFeatureInterface to DriverFeatureProviderInterface
• All instances that need to implement features would implement the DriverFeatureProviderInterface

This will allow us to type to the Interface rather than to an abstract class.

Appendix/Additional Info

No response

[tyrsson]

Maybe DriverFeatureAwareInterface. Whichever is more semantically correct. Need to think about that....

[simon-mundy]

I'd like for addFeature to accept only DriverFeatureInterface - currently the implementation accepts an array. I think if an array|iterable container of DriverFeatures is passed, it has to be an addFeatures method, which simply iterates each entry to the addFeature method.

[settermjd]

I'm not as across the code as both of you, but from my reading of the proposal, it makes perfect sense, and is something that I wholeheartedly support.

[tyrsson]

@settermjd the PR I linked to this issue is now ready for review. I'm going to wait until you review it before I merge it.