Skip to content

Conversation

duergner
Copy link

Fixes #102

…se "id" or "name" from UNCEFACT XML for the array output.

Fixes #102
@codecov-io
Copy link

codecov-io commented Feb 26, 2020

Codecov Report

Merging #103 into master will decrease coverage by 0.01%.
The diff coverage is 86.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #103      +/-   ##
============================================
- Coverage     78.91%   78.89%   -0.02%     
- Complexity      306      308       +2     
============================================
  Files             5        5              
  Lines           863      867       +4     
============================================
+ Hits            681      684       +3     
- Misses          182      183       +1
Impacted Files Coverage Δ Complexity Δ
src/EDI/Interpreter.php 90.32% <86.66%> (-0.26%) 85 <2> (+2)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87ee7ab...03df029. Read the comment docs.

@sabas
Copy link
Collaborator

sabas commented Feb 26, 2020

@duergner instead of the constructor, what about making it a flag with a function, like I made in fogglePatching
https://github.com/php-edifact/edifact/blob/master/src/EDI/Interpreter.php#L121

@duergner
Copy link
Author

Changed it as suggested.

Shall I add the fix for the failing tests as well to this PR (even though it would be unrelated)

@sabas
Copy link
Collaborator

sabas commented Feb 26, 2020

Shall I add the fix for the failing tests as well to this PR (even though it would be unrelated)

Yes thank you :)

@duergner
Copy link
Author

Build should come back to green and I added a test for the new functionality

@sabas sabas merged commit 6c9af6b into php-edifact:master Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possibility to have IDs instead of name as output from Interpreter::prepare
3 participants