Skip to content

Created a Proxy to fix pipeline executions in a workflow #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
May 22, 2023

Conversation

sebprt
Copy link
Collaborator

@sebprt sebprt commented May 12, 2023

No description provided.

@sebprt sebprt added the GTM Good to merge label May 12, 2023
@sebprt sebprt requested a review from gplanchat May 12, 2023 09:29
@sebprt sebprt self-assigned this May 12, 2023
Copy link
Contributor

@gplanchat gplanchat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

La classe proxy ne met pas en attente les appels, tu vas impacter la chronologie des appels.

Si tu avais ce code:

$factory = function ($pipeline) {
    $pipeline->extract('A')->transform('B')->load('C')
};

$factory($pipeline);
$pipeline->transform('D')->load('E');

$pipeline->run()

Qui produisait auparavant la chronologie d’appels :

  1. extract('A')
  2. transform('B')
  3. load('C')
  4. transform('D')
  5. load('E')

Tu as maintenant la chronologie d’appels :

  1. transform('D')
  2. load('E')
  3. extract('A')
  4. transform('B')
  5. load('C')

Ce qui produira l'exécution suivante :

  1. extract('A')
  2. transform('B')
  3. load('C')

@sebprt sebprt requested a review from gplanchat May 12, 2023 14:36
@gplanchat gplanchat merged commit 89a1107 into main May 22, 2023
@gplanchat gplanchat deleted the fix/pipeline-execution branch May 22, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GTM Good to merge
Projects
Development

Successfully merging this pull request may close these issues.

3 participants