Added note about async non-goal #942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
dbu
reviewed
Oct 21, 2017
|
|
||
| A separate interface for asynchronous requests can be defined in a separate PSR | ||
| once the promise PSR is accepted. The method signature for asynchronous requests | ||
| has to be different. |
There was a problem hiding this comment.
maybe:
...has to be different from the method signature for synchronous requests because the return type has to be different anyways (Promise vs Response).
| #### Asynchronous HTTP client | ||
|
|
||
| The reason asynchronous support is a non-goal is because a PSR for HTTP clients | ||
| should not define Promises. That should be a separate PSR. Waiting for a such PSR |
There was a problem hiding this comment.
Thinking about a wait part: it only really matters while the PSR is WIP, but afterwards it's not an information. The fact that it should be a separate PSR and at the time of writing there was no such PSR should be enough to be mentioned IMO.
|
@sagikazarmark, better now? |
sagikazarmark
requested changes
Oct 22, 2017
|
|
||
| The reason asynchronous support is a non-goal is because a PSR for HTTP clients | ||
| should not define Promises. That should be a separate PSR. At the time the HTTP | ||
| client PSR was written there where no PSR for Promises. |
There was a problem hiding this comment.
oops, was way to quick there. Thanks
|
Definitely. Just one last small thing. |
dbu
reviewed
Oct 22, 2017
| A separate interface for asynchronous requests can be defined in a separate PSR | ||
| once the promise PSR is accepted. The method signature for asynchronous requests | ||
| has to be different from the method signature for synchronous requests because | ||
| the return types of asynchronous calls will be a Promise. |
There was a problem hiding this comment.
"the return type of asynchronous calls" (return type should be singular here, not plural)
sagikazarmark
approved these changes
Oct 22, 2017
michaelcullum
approved these changes
Oct 23, 2017
dbu
approved these changes
Oct 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will replace php-http#31