Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix compatibility with PHP 8.0.0RC1 #27

Closed
wants to merge 1 commit into from

Conversation

remicollet
Copy link

Perhaps simpler/better to drop compat. with PHP 5 and remove all TSRMLS usage

Need to relax the test suite as float output have changed.

@jaikdean jaikdean mentioned this pull request Jan 28, 2021
@derickr
Copy link
Contributor

derickr commented Jan 28, 2021

I have resolved this by dropping support for PHP 5 instead.

@derickr derickr closed this Jan 28, 2021
@remicollet
Copy link
Author

I have resolved this by dropping support for PHP 5 instead.

+1

@remicollet remicollet deleted the issue-php8rc1 branch January 28, 2021 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants